adding api key to http requests #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzg
approved these changes
Jan 10, 2022
Owner
itzg
left a comment
itzg
left a comment
There was a problem hiding this comment.
Excellent. Later I might swap it out with generic header support, but will get this tagged and released ASAP for you to use.
Owner
|
Oh yeah, the Java 8 compiler doesn't know about the release designations. I think 9 started that. Hmm, could bump the workflow's Java version to 17 since it's now being told to produce Java 8 output. |
Contributor
Author
|
@itzg I believe this is ready to be merged unless you needed anything else done with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all based on what I have found on stack overflow. I have not actually tried any level of integration testing yet.
Source of solution:
https://stackoverflow.com/questions/26552149/how-to-set-x-api-key-in-the-header-of-http-get-request